feat(runtime): introduce experimental.runtimeMode#14254
Conversation
📦 Binary Size-limit
❌ Size increased by 248.25KB from 62.67MB to 62.91MB (⬆️0.39%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📁 react-1kPath:
📁 react-10kPath:
📁 react-5kPath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
Merging this PR will degrade performance by 2.07%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | bundle@threejs-10x-production-sourcemap |
462 ms | 471.8 ms | -2.07% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/runtime-proxy-context-redesign (4aea304) with main (42487d9)
Footnotes
-
36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
14633c9 to
59afc1b
Compare
Deploying rspack with
|
| Latest commit: |
6aaaa72
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ba87ee1.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-runtime-proxy-context.rspack-v2.pages.dev |
5172147 to
55a76d8
Compare
0cc26f1 to
e867c35
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e867c3553b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8363fcebee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8363fce to
c9b28c3
Compare
c9b28c3 to
27ed515
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27ed515612
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
601bdb6 to
6f1342e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f1342e59b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6f1342e to
6aaaa72
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6aaaa723b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6aaaa72 to
2b535e1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e54a9fa2c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28a09dd0a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
28a09dd to
0dc27ce
Compare
3e12758 to
5081faf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5081fafd84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a55debe15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f102bb614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17ede82d2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codspeedbot explain the regression |
Regression analysisI compared the latest head run ( What regressed
Why it's very likely incidental, not a real hot-path regressionBoth benchmarks measure compilation stages that never execute any of the code this PR touches. This PR changes runtime-context rendering (
In both flamegraphs the regressed frames are overwhelmingly memory/cache-bound rather than doing more instructions (e.g. in Recommendation
No code changes are needed for this — it's an explanation, not a fix. If you'd like, I can dig deeper into a specific frame or help confirm by isolating the config-field change. Summary
Was this response helpful? React with 👍 or 👎 to help us improve CodSpeedBot. |
This comment was marked as outdated.
This comment was marked as outdated.
|
📝 Benchmark detail: Open
Base persistent cache hit rate: 👍 Current persistent cache hit rate: 👍 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4aea304969
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
same with the latest main commit and just some new lines in snapshot |
|
@codspeed explain the regression |
Regression analysisI re-checked the latest head run (
What happenedThe earlier flags — the WallTime
On the current head these effects have washed out and all 52 measured benchmarks are within noise. RecommendationNo code changes are needed — this was incidental noise, and the latest run is clean. The remaining warning on the report header is the Unknown Walltime execution environment notice: WallTime benchmarks on standard hosted runners are inherently noisier. For stable WallTime numbers, CodSpeed Macro Runners are recommended; the Simulation benchmarks are deterministic and unaffected by that warning. If you'd like, I can re-run the comparison against any specific base commit or dig into a particular benchmark's flamegraph. Summary
Was this response helpful? React with 👍 or 👎 to help us improve CodSpeedBot. |
Summary
experiments.runtimeModewith the new"rspack"runtime mode while keeping webpack mode as the compatibility path.__rspack_context, including lexical runtime-global declarations and context field binding for runtime modules and normal modules.__rspack_contextwhile preserving webpack-mode runtime-global output such as__webpack_require__.*.__webpack_require__.*references are rewritten to__rspack_context.*without losing member-chain suffixes.